fix(drivers): map UI dump text into ViewNode.text for locators#43
Open
emor wants to merge 3 commits intomobile-next:mainfrom
Open
fix(drivers): map UI dump text into ViewNode.text for locators#43emor wants to merge 3 commits intomobile-next:mainfrom
text into ViewNode.text for locators#43emor wants to merge 3 commits intomobile-next:mainfrom
Conversation
emor
force-pushed
the
fix/viewnode-text-from-ui-dump
branch
from
ade9d1c to
168438d
Compare
gmegidish
reviewed
Apr 23, 2026
| identifier: el.identifier || el.name || undefined, | ||
| value: el.value || undefined, | ||
| text: el.label || undefined, | ||
| text: el.text || el.label || undefined, |
Member
There was a problem hiding this comment.
I believe we must return el.text as it is. if you are expecting a label, you should use .label. it's more deterministic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mobilecli and Mobile Use RPC elements can carry visible copy in
textand accessibility in
label. ViewNode.text was only set fromlabel,so getByText / getByRole name matching missed Android TextView-style
nodes with empty labels. Prefer el.text then el.label.
Addresses GHSA-gh4j-gqv2-49f6; clears npm audit in CI.